feat(playground): add HMS,SQL,glue,s3tables catalog support#2169
feat(playground): add HMS,SQL,glue,s3tables catalog support#2169Shekharrajak wants to merge 2 commits intoapache:mainfrom
Conversation
|
cc @blackmwk @liurenjie1024 |
Shekharrajak
force-pushed
the
feat/playground-hms-catalog
branch
from
ab35451 to
d2a501c
Compare
|
Hi, @Shekharrajak Thanks for this pr! The direction is to use catalog loader to build catalog rather than adding them one by one. |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
Let me check |
…talog builders Replace the hardcoded match on catalog type strings with the iceberg-catalog-loader crate, which provides a generic catalog factory supporting all 5 catalog types (rest, glue, s3tables, hms, sql). The memory catalog is kept as a special case since MemoryCatalogBuilder lives in iceberg core and is not part of the loader registry. This removes the direct dependencies on iceberg-catalog-rest and iceberg-catalog-hms from the playground crate.
Shekharrajak
force-pushed
the
feat/playground-hms-catalog
branch
from
d2a501c to
2029f13
Compare
Shekharrajak
changed the title
|
Hi @blackmwk , Should I add more test case in next PR. Checks are looking fine. |
2 participants
Which issue does this PR close?
What changes are included in this PR?
Add all catalog support to playground using catalog loader
Are these changes tested?
unit test test_parse_hms_catalog